chore(s2n-quic): remove bytes pin and fix new clippy lints #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Aug 2, 2024
| @@ -4,6 +4,7 @@ | |||
| //! This module contains abstractions around the platform on which the | |||
| //! stack is running | |||
|
|
|||
| #![allow(unexpected_cfgs)] | |||
There was a problem hiding this comment.
I think this one we probably could enable, since we do have a build.rs for this crate and I don't think cargo warns on old versions if you emit that directive?
There was a problem hiding this comment.
I tried it, but it does have this warning:
warning: cargo:rustc-check-cfg requires -Zcheck-cfg=output flag
camshaft
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #2289
Description of changes:
The latest bytes release corrects the issue with 1.7.0 so we can remove the pin on the old version, see tokio-rs/bytes#725
I've also fixed some new Clippy lints.
Call-outs:
I disabled the new
unexpected_cfgslint, as the MSRV we use does not support the recommended way to avoid this lint. This can be removed when the MSRV is 1.74.0, see #2292Testing:
Ran clippy +stable locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.